Commit ec5a1429 authored by Kyle B. Johnson's avatar Kyle B. Johnson Committed by GitHub

Version bump to v3.0.11 (#1979)

* make shutdown function less strict. (#1975)

* Fields that have empty keys should be removed. Closes #1977. (#1978)

* bypass validation for unknown field type. (#1976)

* version bump to v3.0.11.
parent 62810265
...@@ -4,7 +4,7 @@ ...@@ -4,7 +4,7 @@
Tags: form, forms, contact form, custom form, form builder, form creator, form manager, form creation, contact forms, custom forms, forms builder, forms creator, forms manager, forms creation, form administration, Tags: form, forms, contact form, custom form, form builder, form creator, form manager, form creation, contact forms, custom forms, forms builder, forms creator, forms manager, forms creation, form administration,
Requires at least: 4.4 Requires at least: 4.4
Tested up to: 4.6 Tested up to: 4.6
Stable tag: 3.0.10 Stable tag: 3.0.11
License: GPLv2 or later License: GPLv2 or later
With a simple drag and drop interface you can create contact forms, email subscription forms, order forms, payment forms, and any other type of form for your WordPress site. With a simple drag and drop interface you can create contact forms, email subscription forms, order forms, payment forms, and any other type of form for your WordPress site.
......
...@@ -265,7 +265,7 @@ class Ninja_Forms { ...@@ -265,7 +265,7 @@ class Ninja_Forms {
// Plugin version // Plugin version
if ( ! defined( 'NF_PLUGIN_VERSION' ) ) if ( ! defined( 'NF_PLUGIN_VERSION' ) )
define( 'NF_PLUGIN_VERSION', '3.0.10' ); define( 'NF_PLUGIN_VERSION', '3.0.11' );
// Plugin Folder Path // Plugin Folder Path
if ( ! defined( 'NF_PLUGIN_DIR' ) ) if ( ! defined( 'NF_PLUGIN_DIR' ) )
......
...@@ -326,7 +326,7 @@ class NF_AJAX_Controllers_Submission extends NF_Abstracts_Controller ...@@ -326,7 +326,7 @@ class NF_AJAX_Controllers_Submission extends NF_Abstracts_Controller
public function shutdown() public function shutdown()
{ {
$error = error_get_last(); $error = error_get_last();
if( $error !== NULL ) { if( $error !== NULL && in_array( $error[ 'type' ], array( E_ERROR, E_CORE_ERROR, E_COMPILE_ERROR, E_USER_ERROR ) ) ) {
$this->_errors[ 'form' ][ 'last' ] = __( 'The server encountered an error during processing.', 'ninja-forms' ); $this->_errors[ 'form' ][ 'last' ] = __( 'The server encountered an error during processing.', 'ninja-forms' );
$this->_errors[ 'last' ] = $error; $this->_errors[ 'last' ] = $error;
$this->_respond(); $this->_respond();
......
...@@ -209,7 +209,7 @@ final class NF_Admin_Menus_Forms extends NF_Abstracts_Menu ...@@ -209,7 +209,7 @@ final class NF_Admin_Menus_Forms extends NF_Abstracts_Menu
* TODO: Replace unique field key checks with a refactored model/factory. * TODO: Replace unique field key checks with a refactored model/factory.
*/ */
$field_key = $field->get_setting( 'key' ); $field_key = $field->get_setting( 'key' );
if( in_array( $field_key, $unique_field_keys ) ){ if( in_array( $field_key, $unique_field_keys ) || '' == $field_key ){
// Delete the field. // Delete the field.
Ninja_Forms()->request( 'delete-field' )->data( array( 'field_id' => $field_id ) )->dispatch(); Ninja_Forms()->request( 'delete-field' )->data( array( 'field_id' => $field_id ) )->dispatch();
......
...@@ -102,7 +102,7 @@ final class NF_Display_Render ...@@ -102,7 +102,7 @@ final class NF_Display_Render
* TODO: Replace unique field key checks with a refactored model/factory. * TODO: Replace unique field key checks with a refactored model/factory.
*/ */
$field_key = $field->get_setting( 'key' ); $field_key = $field->get_setting( 'key' );
if( in_array( $field_key, $unique_field_keys ) ){ if( in_array( $field_key, $unique_field_keys ) || '' == $field_key ){
// Delete the field. // Delete the field.
Ninja_Forms()->request( 'delete-field' )->data( array( 'field_id' => $field_id ) )->dispatch(); Ninja_Forms()->request( 'delete-field' )->data( array( 'field_id' => $field_id ) )->dispatch();
......
...@@ -42,6 +42,11 @@ class NF_Fields_Unknown extends NF_Fields_Hidden ...@@ -42,6 +42,11 @@ class NF_Fields_Unknown extends NF_Fields_Hidden
add_filter( 'nf_sub_hidden_field_types', array( $this, 'hide_field_type' ) ); add_filter( 'nf_sub_hidden_field_types', array( $this, 'hide_field_type' ) );
} }
public function validate( $field, $data )
{
return array(); // Return empty array with no errors.
}
function hide_field_type( $field_types ) function hide_field_type( $field_types )
{ {
$field_types[] = $this->_name; $field_types[] = $this->_name;
......
...@@ -3,7 +3,7 @@ ...@@ -3,7 +3,7 @@
Plugin Name: Ninja Forms Plugin Name: Ninja Forms
Plugin URI: http://ninjaforms.com/ Plugin URI: http://ninjaforms.com/
Description: Ninja Forms is a webform builder with unparalleled ease of use and features. Description: Ninja Forms is a webform builder with unparalleled ease of use and features.
Version: 3.0.10 Version: 3.0.11
Author: The WP Ninjas Author: The WP Ninjas
Author URI: http://ninjaforms.com Author URI: http://ninjaforms.com
Text Domain: ninja-forms Text Domain: ninja-forms
...@@ -51,7 +51,7 @@ if( get_option( 'ninja_forms_load_deprecated', FALSE ) && ! ( isset( $_POST[ 'nf ...@@ -51,7 +51,7 @@ if( get_option( 'ninja_forms_load_deprecated', FALSE ) && ! ( isset( $_POST[ 'nf
/** /**
* @since 3.0 * @since 3.0
*/ */
const VERSION = '3.0.10'; const VERSION = '3.0.11';
/** /**
* @var Ninja_Forms * @var Ninja_Forms
......
...@@ -3,7 +3,7 @@ Contributors: wpninjasllc, kstover, jameslaws, kbjohnson90, klhall1987, wpnzach, ...@@ -3,7 +3,7 @@ Contributors: wpninjasllc, kstover, jameslaws, kbjohnson90, klhall1987, wpnzach,
Tags: form, forms, contact form, custom form, form builder, form creator, form manager, form creation, contact forms, custom forms, forms builder, forms creator, forms manager, forms creation, form administration, Tags: form, forms, contact form, custom form, form builder, form creator, form manager, form creation, contact forms, custom forms, forms builder, forms creator, forms manager, forms creation, form administration,
Requires at least: 4.4 Requires at least: 4.4
Tested up to: 4.6.1 Tested up to: 4.6.1
Stable tag: 3.0.10 Stable tag: 3.0.11
License: GPLv2 or later License: GPLv2 or later
Drag and drop fields in an intuitive UI to create create contact forms, email subscription forms, order forms, payment forms, send emails and more! Drag and drop fields in an intuitive UI to create create contact forms, email subscription forms, order forms, payment forms, send emails and more!
...@@ -102,31 +102,30 @@ For help and video tutorials, please visit our website: [Ninja Forms Documentati ...@@ -102,31 +102,30 @@ For help and video tutorials, please visit our website: [Ninja Forms Documentati
== Upgrade Notice == == Upgrade Notice ==
= 3.0.10 (18 October 2016) = = 3.0.11 (18 October 2016) =
*Bugs:* *Bugs:*
* Fixed a bug with non-visible fields generating empty HTML on display. * Fixed a bug with overly strict error catching that might stall form submission.
* Fixed a bug with dashicons not showing for non-logged in users.
* Fixed a bug with converting fields with 'inside' labels.
* Fixed a bug with showing custom columns in submissions per-form.
* Fixed a bug with field IDs not properly being updated on form publish.
* Fixed a bug with the country field not displaying the country list in the form.
* Fixed a bug with formatting of textareas and merge tags.
* Fixed a bug with displaying calculation values for checkboxes and merge tags.
* Fixed a bug with duplicate fields breaking the builder and form display.
* Fixed a bug with consistency and form cache data for the builder and form display.
*Changes:* *Changes:*
* Added a hook in the JavaScript for the Pikaday datepicker. * Updated field validation to not check required settings on unknown field types.
* Removed the Submission Post Type from the Admin Bar display. * Added a process to remove empty fields without field keys.
* Excluded the Submission Post Type from public query.
* Added better error reporting for 500 Internal Server Errors for troubleshooting.
* Added a cleanup routine for duplicate fields in forms.
== Changelog == == Changelog ==
= 3.0.11 (18 October 2016) =
*Bugs:*
* Fixed a bug with overly strict error catching that might stall form submission.
*Changes:*
* Updated field validation to not check required settings on unknown field types.
* Added a process to remove empty fields without field keys.
= 3.0.10 (18 October 2016) = = 3.0.10 (18 October 2016) =
*Bugs:* *Bugs:*
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment